Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly error messages #747

Closed
wants to merge 21 commits into from
Closed

Friendly error messages #747

wants to merge 21 commits into from

Conversation

sampottinger
Copy link
Collaborator

See #741

WillRabalais04 and others added 20 commits March 24, 2023 01:47
Updates the getStringValue method of the VariableNode class so that it correctly handles multidimensional arrays. The default formatting of multidimensional arrays is to have the size of the first array written in the last set of brackets eg.int[][5]. This changes it so that the returned value has the size of the first array written in the first set of brackets eg.int[5][]. This can parse multidimensional arrays of any size.
Closes Debugger lists immediate array dimension last #606.
Depending on how the Problem is made, the error may be given relative to
start of line or start of tab. Flag indicates to users of Problems which
one they are working with.
Start refactor of #715 to specific optionals.
Fix an issue where tweaks mode wont run if there are semi-transparent
colors in the tab because of a regex issue.
@sampottinger
Copy link
Collaborator Author

sampottinger commented Jul 13, 2023

Hey @WillRabalais04 thanks for starting this and flagging that issue for me on properties. I think you weren't seeing things reflected because #714 is still open. I was hoping to wait for Ben but this will block your work so I'll close #714 and #720 now. Want to make sure it doesn't derail GSoC.

@sampottinger
Copy link
Collaborator Author

@WillRabalais04 - I'll close my PR and open from your fork.

This was referenced Jul 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants